Merge GitTea/master into master

URLNotesGrabberCORE/DataAccess.cs

@@ -80,6 +80,10 @@ namespace URLNotesGrabberCORE
         private static SQLiteConnection? _importConnection;
         private static HashSet<string>? _importBlogCache;
         private static readonly object _importSessionLock = new object();
+        // AddAPICount/UpdateAPICount run once per API call. A schema-level failure there repeats
+        // identically every time, so log each distinct message once instead of per call.
+        private static readonly HashSet<string> _apiCountFailuresLogged = new HashSet<string>();
+        private static readonly object _apiCountFailureLock = new object();
 
         static DataAccess()
         {
@@ -654,21 +658,40 @@ namespace URLNotesGrabberCORE
 
                 // Use INSERT OR IGNORE to avoid UNIQUE constraint errors when the date row already exists.
                 // Also explicitly initialize APICount to 0 in case the table has no default.
-                string sql = "INSERT OR IGNORE INTO DailyAPICount (Date, APICount, DateCreated) values(@date, 0, @DateCreated)";
+                //
+                // DailyAPICount is (Date TEXT PK, APICount INTEGER) — the crawler never creates or
+                // migrates this table, and no code reads a creation timestamp off it, so the insert
+                // names only those two columns. Naming a DateCreated column here used to throw
+                // "no such column: DateCreated" into a silent catch, which meant the day's row was
+                // never created and the tally sat at 0 for months.
+                string sql = "INSERT OR IGNORE INTO DailyAPICount (Date, APICount) values(@date, 0)";
                 using (SQLiteCommand command = new SQLiteCommand(sql, connection))
                 {
                     command.Parameters.AddWithValue("@date", DateTime.Today.ToShortDateString());
-                    command.Parameters.AddWithValue("@DateCreated", DateTime.Now.ToString("yyyy-MM-dd HH:mm:ss"));
                     command.ExecuteNonQuery();
                 }
             }
             catch (Exception ex)
             {
                 // Breakpoint here
-                //Console.WriteLine(ex.Message);
+                ReportAPICountFailure($"Error creating the row for {DateTime.Today.ToShortDateString()}: {ex.Message}");
             }
         }
 
+        // Bookkeeping writes that fail identically on every API call would flood the console, but
+        // swallowing them entirely is what hid the DateCreated bug. Log each distinct message once.
+        // Messages embed today's date, so a date rollover reports afresh.
+        private static void ReportAPICountFailure(string message)
+        {
+            lock (_apiCountFailureLock)
+            {
+                if (!_apiCountFailuresLogged.Add(message))
+                    return;
+            }
+
+            Console.WriteLine($"[DailyAPICount] {message}");
+        }
+
         public static bool AddNote(string rootBlogName, string noteBlogName, long postID, long timestamp, string type, string? DBPath = null)
         {
             DBPath ??= GetDefaultDbPath();
@@ -1085,7 +1108,9 @@ namespace URLNotesGrabberCORE
             using SQLiteConnection connection = new SQLiteConnection("Data Source=" + DBPath);
             int count = 0;
 
-            try { AddAPICount(); } catch { }
+            // AddAPICount reports its own failures; this guard only stops a connection-level
+            // problem from taking down the read below.
+            try { AddAPICount(); } catch (Exception ex) { ReportAPICountFailure($"AddAPICount failed: {ex.Message}"); }
 
             try
             {
@@ -1093,6 +1118,7 @@ namespace URLNotesGrabberCORE
 
                 string sql = "SELECT APICount FROM DailyAPICount WHERE [Date] = @date";
 
+                bool rowFound = false;
                 using (SQLiteCommand command = new SQLiteCommand(sql, connection))
                 {
                     command.Parameters.AddWithValue("@date", DateTime.Today.ToShortDateString());
@@ -1100,10 +1126,16 @@ namespace URLNotesGrabberCORE
                     {
                         while (reader.Read())
                         {
+                            rowFound = true;
                             count = reader.GetInt32(0); // Assuming Id is the first column
                         }
                     }
                 }
+
+                // A missing row means AddAPICount did not take. Returning a silent 0 here is what
+                // made the tally look merely idle rather than broken.
+                if (!rowFound)
+                    ReportAPICountFailure($"No row for {DateTime.Today.ToShortDateString()} after AddAPICount - reported count of 0 is not a real tally.");
             }
             catch (Exception ex)
             {
@@ -1750,7 +1782,11 @@ namespace URLNotesGrabberCORE
                 {
                     command.Parameters.AddWithValue("@APICount", APICount);
                     command.Parameters.AddWithValue("@date", DateTime.Today.ToShortDateString());
-                    command.ExecuteNonQuery();
+
+                    // No row for today means this UPDATE matched nothing and the increment was
+                    // thrown away, while the value returned below still looks like a real count.
+                    if (command.ExecuteNonQuery() == 0)
+                        ReportAPICountFailure($"UPDATE matched no row for {DateTime.Today.ToShortDateString()} - the count of {APICount} was not persisted.");
                 }
             }
             catch (Exception ex)